New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗 Update @percy/percy-puppeteer to v1.x #25176
🏗 Update @percy/percy-puppeteer to v1.x #25176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really excited to see this happen! Some initial comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked out this branch on a Macbook and sanity tested commands like gulp dist
and gulp check-types
, both of which use execScriptAsync
under the covers. Everything looks good so far. Thanks for doing this!
* Update @percy/percy-puppeteer to v1.x * Removed no-longer used lines from .gitignore * Await until all subprocesses exit * Replace command shell on Unix from `/bin/sh` to `/bin/bash` * Change how child processes are spawn to align with child_process.spawn docs
This reverts commit 7a0a66f.
…5176)" (ampproject#25213)" This reverts commit d134d30.
…ampproject#25221) * Revert "Revert "🏗 Update @percy/percy-puppeteer to v1.x (ampproject#25176)" (ampproject#25213)" This reverts commit d134d30. * Do not expect a build when running with --empty
* Update @percy/percy-puppeteer to v1.x * Removed no-longer used lines from .gitignore * Await until all subprocesses exit * Replace command shell on Unix from `/bin/sh` to `/bin/bash` * Change how child processes are spawn to align with child_process.spawn docs
…ampproject#25221) * Revert "Revert "🏗 Update @percy/percy-puppeteer to v1.x (ampproject#25176)" (ampproject#25213)" This reverts commit d134d30. * Do not expect a build when running with --empty
Fixes #24869
This PR updates the @percy/percy-puppeteer dependency from v0.4.0 to v1.0.8, and also:
Major:
--verbose
to the taskMinor:
/bin/sh
to/bin/bash
per Can't kill child process travis-ci/travis-ci#704 (comment)