Unrevert "🏗 Update @percy/percy-puppeteer to v1.x (#25176)" #25221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5176)" (ampproject#25213)" This reverts commit d134d30.
|
Hey @estherkim, these files were changed:
Hey @rsimha, these files were changed:
|
danielrozenberg
force-pushed
the
percy-puppeteer-redux
branch
from
dbc0efe
to
176cbac
Compare
rsimha
approved these changes
Oct 23, 2019
estherkim
approved these changes
Oct 23, 2019
joshuarrrr
pushed a commit
to Parsely/amphtml
that referenced
this pull request
Oct 23, 2019
…ampproject#25221) * Revert "Revert "🏗 Update @percy/percy-puppeteer to v1.x (ampproject#25176)" (ampproject#25213)" This reverts commit d134d30. * Do not expect a build when running with --empty
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
…ampproject#25221) * Revert "Revert "🏗 Update @percy/percy-puppeteer to v1.x (ampproject#25176)" (ampproject#25213)" This reverts commit d134d30. * Do not expect a build when running with --empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which was reverted in #25213 + fix for the
--emptybug that manifested