🐛 Change to using setTimeout to avoid muted unhandledrejections #25342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also directly calls into the globally installed error reporting function. Re: ampproject#25289 It seems HTML spec is unlikely to change: whatwg/html#5051
dreamofabear
approved these changes
Oct 31, 2019
| @@ -106,7 +106,8 @@ function isPatched(win) { | |||
| * @param {!Error} error | |||
| */ | |||
| function rethrowAsync(error) { | |||
| new /*OK*/ Promise(() => { | |||
| setTimeout(() => { | |||
| self.__AMP_REPORT_ERROR(error); | |||
There was a problem hiding this comment.
Do we know for sure that setReportError() will be called by this point?
There was a problem hiding this comment.
Yes, this can't happen until an AMP element has been created, which happens after the log reporter is setup.
|
Hm, this might be causing local and PR test failures for me: |
|
16bf905 seems to fix it. |
|
*fixed one instance. Tracking down these async Can't cleanly check for "test mode" here, so maybe we can store these errors somewhere and throw them periodically instead? |
|
Merged master and the test failures are no longer happening on my PR #25066. 🤷♂ |
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
…ject#25342) It also directly calls into the globally installed error reporting function. Re: ampproject#25289 It seems HTML spec is unlikely to change: whatwg/html#5051
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also directly calls into the globally installed error reporting function.
Re: #25289
It seems HTML spec is unlikely to change: whatwg/html#5051