🏗 Increase karma browser activity timeout to 5min #26887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hopefully the heartbeat will reduce the need for this, but for now I think this will help flakes a lot |
rsimha
pushed a commit
that referenced
this pull request
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Karma runs our integration tests in a browser, it can take a while for results to be reported. This is increasingly relevant on slow browsers as the number of integration tests in our suite grows. Right now, the suite (including setup and teardown) does not always finish during this window, especially when there is a high Sauce load from many parallel Travis builds.
It impacts Chrome the most, since we execute many of our tests on Chrome (versus IE 11, which includes only a single integration test).
This PR ups the activity timeout from 2 minutes to 5 minutes, which should resolve the majority of tests that currently fail due to message timeout errors.