Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "馃彈 Increase karma browser activity timeout to 5min" #26955

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

rcebulko
Copy link
Contributor

@rcebulko rcebulko commented Feb 24, 2020

Reverts #26887

There's a bigger bug to be fixed; beta browser runs are not being batched. Rolling back until the underlying bug is found

@rsimha
Copy link
Contributor

rsimha commented Feb 24, 2020

Force merging to unblock development.

@rsimha rsimha merged commit ae9d6dc into master Feb 24, 2020
@estherkim
Copy link
Collaborator

There's a bigger bug to be fixed; beta browser runs are not being batched. Rolling back until the underlying bug is found

There are only 2 beta browsers. By batching do you mean running them 1 by 1?

@estherkim
Copy link
Collaborator

It it helps, #24323 has context on why browserNoActivityTimeout was originally changed from 15 min to 2.

@rsimha
Copy link
Contributor

rsimha commented Feb 25, 2020

There's a bigger bug to be fixed; beta browser runs are not being batched.

There are only two beta browsers on which integration tests run. I think the real issue is in running tests in parallel on several stable browsers with a large browserNoActivityTimeout.

As @estherkim said, I don't think this is a bug so much as something that didn't work well with increasing browserNoActivityTimeout. It will help to first understand how all these timeout values interact. I think it's also worth restoring the missing heartbeat functionality and seeing what difference it makes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants