✨Random Subdomains for SafeFrame #27393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
requested review from
lannka
and removed request for
lannka and
cramforce
|
This pull request introduces 1 alert when merging 142bac8 into 054d3e3 - view on LGTM.com new alerts:
|
|
Just wondering if there was any update here. No worries if things are delayed a bit! :) |
keithwrightbos
requested changes
Apr 3, 2020
ryanhugh
commented
Apr 7, 2020
extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js
Outdated
Show resolved
Hide resolved
keithwrightbos
requested changes
Apr 8, 2020
keithwrightbos
requested changes
Apr 8, 2020
extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js
Outdated
Show resolved
Hide resolved
extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js
Outdated
Show resolved
Hide resolved
ldoroshe
pushed a commit
to ldoroshe/amphtml
that referenced
this pull request
May 8, 2020
* random subdomain for each safeframe * fixed some tests * experiment * fix * added experiment * fix * fix * fix * linting * linting * fixes * linting * experiment changes * experiment changes * experiment changes * linting * linting * linting * experiment fix * revert adsense changes * stuff * stuff * added tests * added more tests * changed crypto code a bit * linting * linting * linting * linting * more changes * update experiment * use the existing fn * lint * update * update * updatetests * update * update * whitespace commit just to re-run the tests * whitespace commit just to re-run the tests * empty commit to re-run tests * empty commit to re-run tests * empty commit to re-run flakey tests * empty commit to re-run flakey tests * empty commit to re-run flakey tests * empty commit to re-run flakey tests * empty commit to re-run flakey tests 2 * empty commit to re-run flakey tests 3 * empty commit to re-run flakey tests 4 * empty commit to re-run flakey tests 5 * empty commit to re-run flakey tests 6 * empty commit to re-run flakey tests 7 * empty commit to re-run flakey tests 8 * empty commit to re-run flakey tests 9 * empty commit to re-run flakey tests 10 * empty commit to re-run flakey tests 11 * empty commit to re-run flakey tests 12 * empty commit to re-run flakey tests 13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an experiment to use random subdomains for Safeframe. This will provide more isolation between creatives. We intend to make each subdomain completely random - a random string will be generated for each ad slot on every page. Google is experimenting with this same change on non-AMP pages too.
AMP has had similar discussions recently about changing this behavior for NameFrame: #27091
Let me know if I should make an i2i.