toggleLoading: remove force paramater

[samouri]

summary
The opt_force attribute for custom-element.toggleLoading is used to force an element to reshow its loading indicator even if isLoadingEnabled returns false. This behavior is only used via mutatedAttributesCallback (amp-bind) in amp-list and amp-twitter.

By taking advantage of base-element.isLoadingReused within isLoadingEnabled, I think we can remove the need for a force option.

testing done

• all unit tests still pass
• manually check amp-list
• manually check amp-twitter

[dreamofabear]

Nice find that force in toggleLoading can be subsumed by isLoadingReused.

[dreamofabear]

Man these codepaths are so messy. Another thing I noticed: we should avoid calling Timer.delay if loading is not enabled. It's kind of expensive (see in profiler).

[samouri]

we should avoid calling Timer.delay if loading is not enabled. It's kind of expensive (see in profiler).

Happy to pursue in a separate PR! Unless you think this PR directly exacerbates the issue.

[dreamofabear]

Thanks for cleaning this up. LGTM as long as we manually verify that amp-list/amp-twitter works as expected.

[lgtm-com]

This pull request introduces 1 alert when merging b1fb267 into c21d89a - view on LGTM.com

new alerts:

• 1 for Syntax error

[lgtm-com]

This pull request introduces 1 alert when merging fd1b388 into 680f8cf - view on LGTM.com

new alerts:

• 1 for Syntax error