Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip amp-consent e2e test #27662

Merged
merged 9 commits into from
Apr 17, 2020
Merged

Unskip amp-consent e2e test #27662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fd7573a
test
zhouyx Apr 9, 2020
273635e
lint
zhouyx Apr 9, 2020
b98ba31
skip another flaky test
zhouyx Apr 9, 2020
44f4e48
revert promise
zhouyx Apr 9, 2020
c48fe93
unskip carousel test
zhouyx Apr 9, 2020
5067a21
add promise
zhouyx Apr 10, 2020
80b1f19
use sleep()
zhouyx Apr 17, 2020
1a6b692
import
zhouyx Apr 17, 2020
1bfafd4
3sec
zhouyx Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions extensions/amp-consent/0.1/test-e2e/test-amp-consent-client-side.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
verifyElementsBuilt,
verifyPromptsHidden,
} from './common';
import sleep from 'sleep-promise';

describes.endtoend(
'amp-consent',
Expand All @@ -36,7 +37,7 @@ describes.endtoend(
controller = env.controller;
});

it.skip('should work with client side decision', async () => {
it('should work with client side decision', async () => {
resetAllElements();
const currentUrl = await controller.getCurrentUrl();

Expand Down Expand Up @@ -95,7 +96,9 @@ describes.endtoend(
'postPromptUi': false,
});

// Check the analytics request consentState
// Check the analytics request consentState. Wait for 1 second for the
// request to arrive to avoid flaky test.
await sleep(3000);
await expect(
'http://localhost:8000/amp4test/request-bank/e2e/deposit/tracking?consentState=sufficient'
).to.have.been.sent;
Expand Down
8 changes: 5 additions & 3 deletions extensions/amp-consent/0.1/test-e2e/test-amp-consent-server-side.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
verifyElementsBuilt,
verifyPromptsHidden,
} from './common';
import sleep from 'sleep-promise';

describes.endtoend(
'amp-consent',
Expand All @@ -36,8 +37,7 @@ describes.endtoend(
controller = env.controller;
});

//TODO (micajuineho): Unskip flaky test
it.skip('should respect server side decision and persist it', async () => {
it('should respect server side decision and persist it', async () => {
resetAllElements();

const currentUrl = await controller.getCurrentUrl();
Expand Down Expand Up @@ -79,7 +79,9 @@ describes.endtoend(
'postPromptUi': false,
});

// Check the analytics request consentState
// Check the analytics request consentState. Wait for 1 second for the
// request to arrive to avoid flaky test.
await sleep(3000);
await expect(
'http://localhost:8000/amp4test/request-bank/e2e/deposit/tracking?consentState=insufficient'
).to.have.been.sent;
Expand Down