Unskip amp-consent e2e test #27662
Merged
Unskip amp-consent e2e test #27662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micajuine-ho
approved these changes
Apr 17, 2020
Comment on lines
83
to
85
| await new Promise((resolve) => { | ||
| setTimeout(resolve, 1000); | ||
| }); |
There was a problem hiding this comment.
I believe in test-amp-consent-server-side-expire-cache.jswe are waiting 3 seconds instead of 1, do you think 1 second will suffice here?
There was a problem hiding this comment.
Ha didn't know we have await sleep(), I'll switch to that.
1 sec seemed to work fine. Any reason 3 seconds is chosen? We can always extend later.
There was a problem hiding this comment.
I think you'll have to import it though! It's called sleep-promise
There was a problem hiding this comment.
iirc, @estherkim found 3 seconds to be the most reliable for that test
There was a problem hiding this comment.
ok, switched to 3secs
estherkim
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't reproduce the test failure locally. Tried the fix a few times on travis, seemed to work.
Confirmed with @estherkim
await expect(url).to.have.been.sentonly check the urls till the check is invoked.I added a timeout before verifying the outgoing request to minimize the flakiness. An ideal fix would be to have something like
await expect(url).to.have.eventually.been.sent.Closes #27634