🏗 Fix sourcemap sources paths #27665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @erwinmombay, these files were changed: |
rcebulko
approved these changes
Apr 9, 2020
kristoferbaxter
approved these changes
Apr 9, 2020
|
Because of the duplicated paths, errors being reported right now aren't being grouped properly, making it hard to tell what's a new error and what isn't. When this is finalized and approved, it may be worth cherry-picking into at least Beta/Experimental |
rsimha
suggested changes
Apr 9, 2020
jridgewell
force-pushed
the
babel-sourcemap-paths
branch
from
2bdfdfd
to
b2e059e
Compare
rsimha
reviewed
Apr 9, 2020
jridgewell
force-pushed
the
babel-sourcemap-paths
branch
from
58b20bb
to
de6e530
Compare
jridgewell
force-pushed
the
babel-sourcemap-paths
branch
from
de6e530
to
576f9d3
Compare
mdmower
reviewed
Apr 11, 2020
kristoferbaxter
approved these changes
Apr 12, 2020
jridgewell
force-pushed
the
babel-sourcemap-paths
branch
from
8503476
to
5eb0e38
Compare
This was referenced Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the sourcemaps' sources paths. Closure treats each source location as being relative to the sourcemap. Unlike regular gulp plugins, Closure pretends the sourcemap lives in the same directory as the compiled file. So, when resolving, it was adding the directory path twice.
And in single pass, we actually never had working sourcemap paths. The paths we always
/src/*, and not the raw.githubusercontent.com they should have been.This also removes a now-unneeded root
thisreplacement, which was being done withgulp-regexp-sourcemaps. For some reason, this removes all of the source paths. Thankfully, it's no longer needed as Closure'sgetGlobalhas been updated to https://github.com/google/closure-compiler/blob/v20200315/src/com/google/javascript/jscomp/js/util/global.js.