Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ CSS support in Storybook and amp-image-slider example #27800

Merged
merged 3 commits into from Apr 20, 2020
Merged

✨ CSS support in Storybook and amp-image-slider example #27800

merged 3 commits into from Apr 20, 2020

Conversation

wassgha
Copy link
Contributor

@wassgha wassgha commented Apr 16, 2020 •
edited

Changes

  • Added support for global and local styling of components inside Storybook through styled-jsx
  • Added an example for using CSS in Storybook by customizing the hints on the amp-image-slider component

/cc @krdwan @dvoytenko @jridgewell

@wassgha wassgha mentioned this pull request Apr 16, 2020
Merged
@wassgha wassgha merged commit 52d22e0 into ampproject:master Apr 20, 2020
samouri pushed a commit to samouri/amphtml that referenced this pull request Apr 21, 2020
@wassgha @samouri
✨ CSS support in Storybook and amp-image-slider example (ampproject…
81512c8 
…#27800)

* Added css support to storybook + amp-image-slider example

* Remove unncessary source maps

* Fixed linter issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvoytenko dvoytenko dvoytenko approved these changes

@rsimha rsimha rsimha approved these changes

@alanorozco alanorozco Awaiting requested review from alanorozco

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wassgha @dvoytenko @rsimha @googlebot @ampprojectbot