📖 [amp-list][storybook][amp] Added basic storybook stories for amp-list #27719
Conversation
|
@wassgha A storybook story for amp-sidebar for your review. I was unable to add custom CSS, do you have any information on how to add CSS to storybook? If so, I may update this PR. |
| // To do: how to add CSS | ||
| //import '!style-loader!css-loader!./Basic-styles.css'; |
There was a problem hiding this comment.
Thanks, I'll add a separate PR to include more use cases with CSS
There was a problem hiding this comment.
The CSS pull request is approved.
| <p> | ||
| Use the buttons below to open / toggle the amp-sidebar. The sidebar | ||
| will be displayed with various navigational elements. | ||
| </p> |
There was a problem hiding this comment.
Usually examples should just be the component itself without any description. If we like we can use the storybook docs addon which allows for this style of inline examples. See https://github.com/storybookjs/storybook/tree/master/addons/docs#docspage
/cc @dvoytenko
There was a problem hiding this comment.
Thanks for the input @wassgha . I am happy to remove the description or move the entire story into a storybook doc.
One thing to note is that it appears that some components do not work in isolation. For amp-list here, at a minimum a button outside of the component is needed to toggle the sidebar into view.
Sounds like we should establish a precedent on how we want to handle potential descriptions and other elements outside of the component in a story.
There was a problem hiding this comment.
Awesome! Descriptions moved to comments as we discussed in latest commit.
* Create basic stories for amp-sidebar in storybook * Update amp-sidebar story to not have description in story, description moved to comments * Re-kickoff travis
krdwan
changed the title
Added two stories in storybook for amp-list