Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #27159 and #27521 #27768

Merged
merged 2 commits into from Apr 14, 2020
Merged

Revert #27159 and #27521 #27768

merged 2 commits into from Apr 14, 2020

Conversation

caroqliu
Copy link
Contributor

No description provided.

@amp-owners-bot
Copy link

Hey @ampproject/wg-caching, these files were changed:

extensions/amp-list/0.1/test/validator-amp-list.html
extensions/amp-list/0.1/test/validator-amp-list.out
extensions/amp-list/validator-amp-list.protoascii
validator/testdata/amp4email_feature_tests/amp_list.html
validator/testdata/amp4email_feature_tests/amp_list.out

@caroqliu caroqliu mentioned this pull request Apr 14, 2020
Closed
@nainar nainar self-requested a review April 14, 2020 22:56
nainar
nainar approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@nainar nainar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving UI reverts

@nainar nainar requested a review from Gregable April 14, 2020 22:57
@Gregable Gregable removed the request for review from honeybadgerdontcare April 14, 2020 23:04
@danielrozenberg danielrozenberg merged commit dceac64 into ampproject:master Apr 14, 2020
danielrozenberg pushed a commit that referenced this pull request Apr 14, 2020
@caroqliu @danielrozenberg
Revert #27159 and #27521 (#27768)
98d4529 
* Revert "[amp-list]: make layout=container and load-more mutually exclusive (#27521)"

This reverts commit 14329bc.

* Revert "Support layout=container in amp-list (#27159)"

This reverts commit b0187b7.

(cherry picked from commit dceac64)
danielrozenberg pushed a commit that referenced this pull request Apr 14, 2020
@caroqliu @danielrozenberg
Revert #27159 and #27521 (#27768)
0fef66f 
* Revert "[amp-list]: make layout=container and load-more mutually exclusive (#27521)"

This reverts commit 14329bc.

* Revert "Support layout=container in amp-list (#27159)"

This reverts commit b0187b7.

(cherry picked from commit dceac64)
twifkak added a commit to twifkak/amphtml that referenced this pull request Apr 15, 2020
@twifkak
cl/306685743 Revision bump for ampproject#27768
40befdd
@twifkak twifkak mentioned this pull request Apr 15, 2020
Merged
twifkak added a commit that referenced this pull request Apr 16, 2020
@twifkak
Validator rollup (#27784)
39c4d67 
* cl/305561778 Revision bump for #27624

* cl/305733898 CSS validation changes.

* cl/306335254 Revision bump for #27709

* cl/306343181 Fix javascript validator symbol export.

* cl/306685743 Revision bump for #27768

Co-authored-by: Greg Grothaus <greggrothaus@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gregable Gregable Gregable approved these changes

@nainar nainar nainar approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable WG: caching
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@caroqliu @Gregable @nainar @danielrozenberg @googlebot @ampprojectbot