Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator rollup #27784

Merged
merged 5 commits into from Apr 16, 2020
Merged

Validator rollup #27784

merged 5 commits into from Apr 16, 2020

Conversation

twifkak
Copy link
Member

@twifkak twifkak commented Apr 15, 2020

@amp-owners-bot
Copy link

Hey @ampproject/wg-caching, these files were changed:

validator/engine/validator.js
validator/engine/validator_test.js
validator/testdata/actions_feature_tests/css_length.html
validator/testdata/actions_feature_tests/css_length.out
validator/testdata/amp4email_feature_tests/css_length.html
validator/testdata/amp4email_feature_tests/css_length.out
validator/testdata/feature_tests/css_length.html
validator/testdata/feature_tests/css_length.out
validator/testdata/feature_tests/incorrect_custom_style.html
validator/testdata/feature_tests/incorrect_custom_style.out
validator/testdata/feature_tests/inline_style.html
validator/testdata/feature_tests/inline_style.out
validator/testdata/transformed_feature_tests/css_length.html
validator/testdata/transformed_feature_tests/css_length.out
validator/validator-css.protoascii
validator/validator-main.protoascii
validator/validator.pb.go
validator/validator.proto

@twifkak
Copy link
Member Author

twifkak commented Apr 15, 2020

https://travis-ci.org/github/ampproject/amphtml/jobs/675444272 Java tests timed out. Closed and re-opened PR to trigger a Travis re-run. 🤞

@honeybadgerdontcare
Copy link
Contributor

@GeorgeLuo can we remove validator-java tests from blocking?

@twifkak twifkak closed this Apr 16, 2020
@twifkak twifkak reopened this Apr 16, 2020
@twifkak
Copy link
Member Author

twifkak commented Apr 16, 2020

@banaag Travis passes now; please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants