-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator rollup #27784
Merged
Merged
Validator rollup #27784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
twifkak
commented
Apr 15, 2020
- cl/306685743 Revision bump for Revert #27159 and #27521 #27768
- cl/306343181 Fix javascript validator symbol export.
- cl/306335254 Revision bump for Ship remote page attachments #27709
- cl/305733898 CSS validation changes.
- cl/305561778 Revision bump for 🐛Require src attribute in amp-ad-custom #27624
Hey @ampproject/wg-caching, these files were changed:
|
https://travis-ci.org/github/ampproject/amphtml/jobs/675444272 Java tests timed out. Closed and re-opened PR to trigger a Travis re-run. 🤞 |
@GeorgeLuo can we remove validator-java tests from blocking? |
@banaag Travis passes now; please review. |
banaag
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.