✨ amp-animation internals can take a scope element #27887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @newmuis, these files were changed: |
alanorozco
commented
Apr 21, 2020
alanorozco
commented
Apr 21, 2020
gmajoulet
approved these changes
Apr 21, 2020
8 tasks
dvoytenko
suggested changes
Apr 21, 2020
dvoytenko
approved these changes
Apr 21, 2020
| @@ -60,7 +64,7 @@ const DEFAULT_EASING = 'cubic-bezier(0.4, 0.0, 0.2, 1)'; | |||
| * TODO(alanorozco): maybe memoize? | |||
| */ | |||
| export function hasAnimations(element) { | |||
| const selector = `${ANIMATABLE_ELEMENTS_SELECTOR},amp-story-animation`; | |||
| const selector = `${ANIMATABLE_ELEMENTS_SELECTOR},>amp-story-animation`; | |||
There was a problem hiding this comment.
TIL that scopedQuerySelector accepts comma-separated selectors. This is cool.
There was a problem hiding this comment.
It's been able for a little over a year now, I think :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #27758
Buildernow takes options:{scope: (!Node|undefined)}. This scopes the selector in the effect spec.<amp-story-animation>scopes to its parent<amp-story-page>.