Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track features before launch of <amp-story-animation> #27758

Closed
3 of 8 tasks
alanorozco opened this issue Apr 14, 2020 · 1 comment
Closed
3 of 8 tasks

Track features before launch of <amp-story-animation> #27758

alanorozco opened this issue Apr 14, 2020 · 1 comment
Labels
Stale Inactive for one year or more Type: Feature Request

Comments

@alanorozco
Copy link
Member

alanorozco commented Apr 14, 2020 •
edited

@alanorozco alanorozco mentioned this issue Apr 20, 2020
Merged
alanorozco added a commit that referenced this issue Apr 21, 2020
@alanorozco
✨ amp-animation internals can take a scope element (#27887)
a553688 
Partial for #27758

`Builder` now takes options: `{scope: (!Node|undefined)}`. This scopes the selector in the effect spec.

`<amp-story-animation>` scopes to its parent `<amp-story-page>`.
@alanorozco alanorozco mentioned this issue Apr 23, 2020
Merged
alanorozco added a commit that referenced this issue Apr 27, 2020
@alanorozco
✨ Sequence <amp-story-animation> (#27985)
e4a84da 
Partial for #27758

1. Restructure `StoryAnimationConfigDef` so that it contains a `WebAnimationDef` without duplicate props.

2. Wrap `<amp-story-animation>` specs in a `StoryAnimationConfigDef`.

3. `<amp-story-animation>` passes the id of a `source` it will wait for. It can also define its own sequencing id.
This was referenced Apr 30, 2020
Merged
Merged
alanorozco added a commit that referenced this issue May 7, 2020
@alanorozco
✨ amp-animation: add x(), y(), rescale by scope element's transform (#…
471bbb9 
…28146)

Partial for #27758

- Optionally calculates a scaling factor based on the scope element's transform (`options.scaleByScope`).

- Introduces `x()` and `y()`.
ldoroshe pushed a commit to ldoroshe/amphtml that referenced this issue May 8, 2020
@alanorozco @ldoroshe
✨ Sequence <amp-story-animation> (ampproject#27985)
787b554 
Partial for ampproject#27758

1. Restructure `StoryAnimationConfigDef` so that it contains a `WebAnimationDef` without duplicate props.

2. Wrap `<amp-story-animation>` specs in a `StoryAnimationConfigDef`.

3. `<amp-story-animation>` passes the id of a `source` it will wait for. It can also define its own sequencing id.
alanorozco added a commit that referenced this issue May 20, 2020
@alanorozco
✅ Validation for <amp-story-animation> (#28245)
99a3989 
Partial for #27758

Effectively launches `<amp-story-animation>`
@stale
Copy link

stale bot commented Oct 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Oct 28, 2021
@stale stale bot closed this as completed Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale Inactive for one year or more Type: Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alanorozco