Turn on analytics-chunks in canary #28069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerivq
approved these changes
Apr 28, 2020
|
cc @choumx |
|
Should be fine, just note that canary metrics now are impacted by 3+ active experiments. Are you planning on enabling it in prod soon? |
|
Yes, I am hoping to enable it in prod next week. |
|
Ideally this should help with reducing long tasks. I'm not seeing that. The three experiments could be a reason. But I see no major regression. And since the change doesn't apply to inabox, I feel it's safe to enable. |
|
Sounds good, thanks. |
This was referenced May 7, 2020
ldoroshe
pushed a commit
to ldoroshe/amphtml
that referenced
this pull request
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.