Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ amp-animation: add x(), y(), rescale by scope element's transform #28146

Merged
merged 14 commits into from May 7, 2020
Merged

✨ amp-animation: add x(), y(), rescale by scope element's transform #28146

merged 14 commits into from May 7, 2020

Conversation

alanorozco
Copy link
Member

@alanorozco alanorozco commented Apr 30, 2020 •
edited

Partial for #27758

  • Optionally calculates a scaling factor based on the scope element's transform (options.scaleByScope).

  • Introduces x() and y().

@amp-owners-bot
Copy link

amp-owners-bot bot commented Apr 30, 2020 •
edited

Hey @newmuis, @Enriqe! These files were changed:

extensions/amp-story/1.0/animation.js
extensions/amp-story/1.0/test/test-animation.js

@alanorozco alanorozco changed the title ✨ amp-animation, add x(), y(), rescale by scope element's transform ✨ amp-animation: add x(), y(), rescale by scope element's transform Apr 30, 2020
@alanorozco alanorozco mentioned this pull request Apr 30, 2020
Closed
8 tasks
dvoytenko
dvoytenko suggested changes Apr 30, 2020
View reviewed changes
extensions/amp-animation/0.1/parsers/css-expr-ast.js Outdated Show resolved Hide resolved
extensions/amp-animation/0.1/parsers/css-expr-ast.js Outdated Show resolved Hide resolved
extensions/amp-animation/0.1/parsers/css-expr-ast.js Outdated Show resolved Hide resolved
extensions/amp-animation/0.1/parsers/css-expr-impl.jison Outdated Show resolved Hide resolved
extensions/amp-animation/0.1/web-animations.js Outdated Show resolved Hide resolved
extensions/amp-animation/0.1/web-animations.js Outdated Show resolved Hide resolved
extensions/amp-animation/0.1/web-animations.js Outdated Show resolved Hide resolved
extensions/amp-story/1.0/animation.js Outdated Show resolved Hide resolved
dvoytenko
dvoytenko approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@dvoytenko dvoytenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with couple of nits.

extensions/amp-animation/0.1/parsers/css-expr-impl.jison Outdated Show resolved Hide resolved
extensions/amp-animation/0.1/web-animations.js Outdated Show resolved Hide resolved
@amp-bundle-size amp-bundle-size bot requested a review from rcebulko May 6, 2020 19:01
@rcebulko rcebulko removed their request for review May 6, 2020 19:55
@alanorozco alanorozco merged commit 471bbb9 into ampproject:master May 7, 2020
@alanorozco alanorozco deleted the animation-dims branch May 7, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvoytenko dvoytenko dvoytenko approved these changes

@gmajoulet gmajoulet gmajoulet approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alanorozco @dvoytenko @gmajoulet @googlebot @ampprojectbot