✨ Added new ad network vlyby #30205

damjan25 · 2020-09-11T19:50:36Z

✨Implements vlyby ad network

google-cla · 2020-09-11T19:50:41Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

powerivq · 2020-09-11T19:54:15Z

Hi

Please fix the CLA issue. There are commits in this PR authored by non-CLA'ed person.

damjan25 · 2020-09-11T19:55:45Z

@googlebot I fixed it.

google-cla · 2020-09-11T19:55:50Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

powerivq · 2020-09-11T20:16:02Z

@damjan25

It is not about you, but about Martin Schwager (as you can see in the commit list).

google-cla · 2020-09-11T20:24:22Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

vlybymschwage · 2020-09-11T20:56:43Z

@googlebot I fixed it.

google-cla · 2020-09-11T20:56:47Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-09-11T21:13:31Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-09-11T21:34:07Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

powerivq · 2020-09-12T00:46:24Z

I don't see an email on Martin Schwager's commit. You will need to fix that commit in order for CLA test to pass. Each commit should be authored by one with CLA covered.

google-cla · 2020-09-12T17:11:32Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

vlybymschwage · 2020-09-12T17:32:19Z

@googlebot I fixed it.

google-cla · 2020-09-12T17:32:27Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

vlybymschwage · 2020-09-12T17:33:28Z

@googlebot I consent.

google-cla · 2020-09-12T17:33:36Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

mschwage · 2020-09-12T17:34:17Z

@googlebot I consent.

google-cla · 2020-09-12T17:34:23Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

MartinSchwager · 2020-09-12T17:34:49Z

@googlebot I consent.

damjan25 · 2020-09-12T18:54:04Z

@googlebot I consent.

lgtm-com · 2020-09-13T17:33:19Z

This pull request introduces 1 alert when merging 1efa2b3 into 767775f - view on LGTM.com

new alerts:

1 for Superfluous trailing arguments

damjan25 · 2020-09-13T20:20:04Z

It keeps failing at this karma test. @powerivq Could this be caused by our code or is this general issue or am I doing something wrong 🤔 ? Because I saw few latest pull requests that have this error. It is a bit weird because earlier I did only linter change and all the tests passed(travis link)

DESCRIBE => AmpViewerMessagingIntegration
  DESCRIBE =>  
    DESCRIBE => Handshake
      IT => should perform polling handshake
        ✗ Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

https://travis-ci.org/github/ampproject/amphtml/builds/726790200

ok looks like there is PR for this: #30124
Hopefully it gets implemented soon 😄

* initial setup * added correct cdn links and added prop for observer * updated readme * added missing comma * removed unused code and fixed linter errors * fixed vlyby readme linter issues * initial setup email added rebase * added correct cdn links and added prop for observer * updated readme * added missing comma * removed unused code and fixed linter errors * fixed vlyby readme linter issues * added allowed_data * fixed prettier error * fixed types * type check err fix * fixed getdata * removed unnecessary global pass down * pass down global fix * fixed missing param * reverted last 2 commits Co-authored-by: Martin Schwager <mschwager@notebooksbilliger.de> Co-authored-by: Martin <martin@samcube.de>

MartinSchwager and others added 3 commits June 9, 2020 22:25

initial setup

d9c0a1b

added correct cdn links and added prop for observer

1c52739

updated readme

89be036

amp-owners-bot bot requested a review from powerivq September 11, 2020 19:50

google-cla bot added the cla: no label Sep 11, 2020

added missing comma

8549ce5

removed unused code and fixed linter errors

9287711

fixed vlyby readme linter issues

d2be7b7

MartinSchwager and others added 7 commits September 12, 2020 19:09

initial setup email added rebase

a3424a9

added correct cdn links and added prop for observer

5433aad

updated readme

354aea4

added missing comma

ca806a7

removed unused code and fixed linter errors

4ed3375

fixed vlyby readme linter issues

894ac04

Merge branch 'vlyby' of github.com:vlyby/amphtml into vlyby

225b297

google-cla bot added cla: yes and removed cla: no labels Sep 12, 2020

damjan25 changed the title ~~Added new ad network vlyby~~ ✨ Added new ad network vlyby Sep 12, 2020

damjan25 added 7 commits September 12, 2020 23:40

added allowed_data

a06ce0e

fixed prettier error

c127dab

fixed types

4e47809

type check err fix

84359c9

fixed getdata

1e58d5e

removed unnecessary global pass down

e037ae6

pass down global fix

1efa2b3

damjan25 added 2 commits September 13, 2020 19:42

fixed missing param

7ba2d17

reverted last 2 commits

ff236f6

powerivq approved these changes Sep 14, 2020

View reviewed changes

powerivq merged commit 80f913d into ampproject:master Sep 14, 2020

ampprojectbot added the PR use: In Beta / Experimental label Sep 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Added new ad network vlyby #30205

✨ Added new ad network vlyby #30205

damjan25 commented Sep 11, 2020

google-cla bot commented Sep 11, 2020

powerivq commented Sep 11, 2020

damjan25 commented Sep 11, 2020

google-cla bot commented Sep 11, 2020

powerivq commented Sep 11, 2020

google-cla bot commented Sep 11, 2020

vlybymschwage commented Sep 11, 2020

google-cla bot commented Sep 11, 2020

google-cla bot commented Sep 11, 2020

google-cla bot commented Sep 11, 2020

powerivq commented Sep 12, 2020 •

edited

google-cla bot commented Sep 12, 2020

vlybymschwage commented Sep 12, 2020

google-cla bot commented Sep 12, 2020

vlybymschwage commented Sep 12, 2020

google-cla bot commented Sep 12, 2020

mschwage commented Sep 12, 2020

google-cla bot commented Sep 12, 2020

MartinSchwager commented Sep 12, 2020

damjan25 commented Sep 12, 2020

lgtm-com bot commented Sep 13, 2020

damjan25 commented Sep 13, 2020 •

edited

✨ Added new ad network vlyby #30205

✨ Added new ad network vlyby #30205

Conversation

damjan25 commented Sep 11, 2020

google-cla bot commented Sep 11, 2020

powerivq commented Sep 11, 2020

damjan25 commented Sep 11, 2020

google-cla bot commented Sep 11, 2020

powerivq commented Sep 11, 2020

google-cla bot commented Sep 11, 2020

vlybymschwage commented Sep 11, 2020

google-cla bot commented Sep 11, 2020

google-cla bot commented Sep 11, 2020

google-cla bot commented Sep 11, 2020

powerivq commented Sep 12, 2020 • edited

google-cla bot commented Sep 12, 2020

vlybymschwage commented Sep 12, 2020

google-cla bot commented Sep 12, 2020

vlybymschwage commented Sep 12, 2020

google-cla bot commented Sep 12, 2020

mschwage commented Sep 12, 2020

google-cla bot commented Sep 12, 2020

MartinSchwager commented Sep 12, 2020

damjan25 commented Sep 12, 2020

lgtm-com bot commented Sep 13, 2020

damjan25 commented Sep 13, 2020 • edited

powerivq commented Sep 12, 2020 •

edited

damjan25 commented Sep 13, 2020 •

edited