-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amp-o2-player added consent data handling #30858
Conversation
Hey @alanorozco! These files were changed:
|
@nainar I apologize for the urgency, but could you please merge this pr at your earliest possible convenience? It is impact on business a lot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lironka thank you for your PR. It looks good to me, however, I want to confirm that you did some manual testing before we merge.
@micajuine-ho hi! I did manual testing and it worked well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Sounds great :D.
@micajuine-ho Hi! Could you, please, merge the pr? I haven't permission to do it. |
Hi ! @lironka, can you force merge a blank/trivial commit. It seems like the Travis job is stuck/not loading, so we need to trigger it again. Additionally, the owners check should not be an issue here, since |
@micajuine-ho HI! I updated but travis still looks as waiting. Do you know what could we do? |
I'm not sure why this is happening. Maybe best shot is just to close this PR and open a new one... |
Hi @lironka, my guess is that Travis is stalling because we migrated from Travis.org to Travis.com on Oct 23, which isn't included in this branch. Please merge this branch with HEAD for the latest Travis config and let's see how that goes. |
@estherkim Hi! I have latest master and don't see any brach with name HEAD. What I need to do for "merge this branch with HEAD" ? |
Hi, what I meant was to get latest (the HEAD commit) from master and merge it to this branch. It looks like this branch was created on Oct 22 and hasn't been merged with master since. Here are the steps to merge with latest - |
@estherkim Hi! thank you I updated. But still my upstream/master has travis.org not travis.com as you mentioned. Are you sure travis.com was merged? |
Hmm, can you try creating another copy with this PR? Maybe the GitHub checks are stuck with the stale Travis config. |
@estherkim Sorry but when I go to https://github.com/ampproject/amphtml/tree/master I see in |
Good eye :) that's a bug, but it shouldn't affect the Travis build. Please try creating a fresh PR, thanks! |
I close this pr due to Travis issue. I reopen it here #31005 |
✨ Added consent data handling to amp-o2-player