Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨amp-o2-player add handling consent data #31005

Merged

Conversation

lironka
Copy link
Contributor

@lironka lironka commented Nov 4, 2020

this is a copy of pr #30858, travis is stuck in that pr.
It is impact on business a lot.

@estherkim HI! this is a copy.

@amp-owners-bot amp-owners-bot bot requested a review from zhouyx November 4, 2020 19:39
@amp-owners-bot
Copy link

amp-owners-bot bot commented Nov 4, 2020

Hey @alanorozco! These files were changed:

extensions/amp-o2-player/0.1/amp-o2-player.js
extensions/amp-o2-player/0.1/test/test-amp-o2-player.js
extensions/amp-o2-player/amp-o2-player.md

@lironka
Copy link
Contributor Author

lironka commented Nov 4, 2020

@estherkim HI! this is a copy pr and the same issue. the pr based on the latest upstream/master

@estherkim
Copy link
Collaborator

Hi @lironka, this is interesting. Can you try logging into travis-ci.com? Once verified that Travis recognizes your account, push a new commit here to re-trigger the build.

If that doesn't work then I'll contact Travis support.

@estherkim
Copy link
Collaborator

To explain, I found this in the Requests section on Travis. So your PR is going through but Travis is blocking it for some reason.
image

@estherkim
Copy link
Collaborator

Same thing :/ I'll send an email. I understand that this is urgent? In order for this to make it into Beta next week, it has to be merged by EOD Friday. @micajuine-ho can help with that in case this isn't resolved by then. Thanks for your patience!

@lironka
Copy link
Contributor Author

lironka commented Nov 4, 2020

@estherkim Hi again. I authorised in Travis and suddenly gat a message Your account has been flagged for potential abuse. Please contact support.
maybe this leads to an issue.

@estherkim
Copy link
Collaborator

Seems like it. I reached out to their support team. You might want to file a ticket with them too.

@lironka
Copy link
Contributor Author

lironka commented Nov 4, 2020

@estherkim Yes. I did, I sent them a ticket.

@zhouyx zhouyx requested review from micajuine-ho and removed request for zhouyx November 5, 2020 00:03
@lironka
Copy link
Contributor Author

lironka commented Nov 5, 2020

@estherkim @micajuine-ho hi! Finally pr had passed the Travis checks. Could you please approve it?

Copy link
Contributor

@micajuine-ho micajuine-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@lironka
Copy link
Contributor Author

lironka commented Nov 5, 2020

@micajuine-ho hi again! thank you. But I can't merge: The base branch restricts merging to authorized users. Could you do it?

@micajuine-ho micajuine-ho merged commit 7cf8a4a into ampproject:master Nov 5, 2020
@lironka
Copy link
Contributor Author

lironka commented Nov 5, 2020

@micajuine-ho thanks a lot!!!!!

@lironka
Copy link
Contributor Author

lironka commented Nov 5, 2020

@micajuine-ho do you know how long it takes to appear in https://cdn.ampproject.org/rtv/ ?

@micajuine-ho
Copy link
Contributor

2 weeks, but since we are in a release freeze right now, it will take 3 weeks I believe.

ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
* amp-o2-player add handling consent data

* am-o2-player added blank comment

* amp-o2 blank comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants