resources: delete LayoutDelayMeter #30989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristoferbaxter
approved these changes
Nov 3, 2020
Can we remove this and reimplement for development builds? We found that the legacy implementation has departed what we want from the new implementation path significantly. |
dvoytenko
approved these changes
Nov 3, 2020
|
I vote we reimplement when we have a need again. I currently fear YAGNI / it'll linger for a long time otherwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
From asking around, it seems as though these metrics are no longer paid attention to.
Alternative to #30970.
Partial for #30620