Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources: delete LayoutDelayMeter #30989

Merged
merged 1 commit into from
Nov 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 0 additions & 24 deletions src/custom-element.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import {
isInternalElement,
isLoadingAllowed,
} from './layout';
import {LayoutDelayMeter} from './layout-delay-meter';
import {ResourceState} from './service/resource';
import {Services} from './services';
import {Signals} from './utils/signals';
Expand Down Expand Up @@ -259,9 +258,6 @@ function createBaseCustomElementClass(win) {
/** @private {boolean} */
this.perfOn_ = perf && perf.isPerformanceTrackingOn();

/** @private {?./layout-delay-meter.LayoutDelayMeter} */
this.layoutDelayMeter_ = null;

if (nonStructThis[dom.UPGRADE_TO_CUSTOMELEMENT_RESOLVER]) {
nonStructThis[dom.UPGRADE_TO_CUSTOMELEMENT_RESOLVER](nonStructThis);
delete nonStructThis[dom.UPGRADE_TO_CUSTOMELEMENT_RESOLVER];
Expand Down Expand Up @@ -1155,9 +1151,6 @@ function createBaseCustomElementClass(win) {
if (isLoadEvent) {
this.signals_.signal(CommonSignals.LOAD_START);
}
if (this.perfOn_) {
this.getLayoutDelayMeter_().startLayout();
}

// Potentially start the loading indicator.
this.toggleLoading(true);
Expand Down Expand Up @@ -1244,9 +1237,6 @@ function createBaseCustomElementClass(win) {
updateInViewport_(inViewport) {
this.implementation_.inViewport_ = inViewport;
this.implementation_.viewportCallback(inViewport);
if (inViewport && this.perfOn_) {
this.getLayoutDelayMeter_().enterViewport();
}
}

/**
Expand Down Expand Up @@ -1651,20 +1641,6 @@ function createBaseCustomElementClass(win) {
}
}

/**
* Returns an optional overflow element for this custom element.
* @return {!./layout-delay-meter.LayoutDelayMeter}
*/
getLayoutDelayMeter_() {
if (!this.layoutDelayMeter_) {
this.layoutDelayMeter_ = new LayoutDelayMeter(
toWin(this.ownerDocument.defaultView),
this.getLayoutPriority()
);
}
return this.layoutDelayMeter_;
}

/**
* Returns an optional overflow element for this custom element.
* @return {?Element}
Expand Down
96 changes: 0 additions & 96 deletions src/layout-delay-meter.js

This file was deleted.

99 changes: 0 additions & 99 deletions test/unit/test-layout-delay-meter.js

This file was deleted.