Sync for validator/cpp/engine #30994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part 1 of 2. With the introduction of module/nomodule the file extension for scripts may be either `.js` or `.mjs` and not always `.js`. This change will allow for the simplification of handling `also_requires_tag` and `also_requires_tag_warning`. The latter is used by `amp-ad` and `amp-video`. The purpose is to allow a single `also_requires_tag_warning` to cover all variations of script types (regular, module, nomodule, module SXG) with a single expression (`amp-ad extension script`). The engine will see this and apply it to any extension script type. That change will come in part 2. This changes: `amp-extname extension .js script` to `amp-extname extension script` `amphtml engine v0.js script` to `amphtml engine script` PiperOrigin-RevId: 339147096
This is part 2 of 2. Part 1 is cl/339147096. The purpose is to allow a single `also_requires_tag_warning` to cover all variations of script types (regular, module, nomodule, module SXG) with a single expression (e.g. `amp-ad extension script`). The engine will see `extension script` and apply it to any extension script type with the same extension spec name. PiperOrigin-RevId: 339898343
honeybadgerdontcare
approved these changes
Nov 3, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* Remove the file extension for script tags in spec_names/messages (`.js`) This is part 1 of 2. With the introduction of module/nomodule the file extension for scripts may be either `.js` or `.mjs` and not always `.js`. This change will allow for the simplification of handling `also_requires_tag` and `also_requires_tag_warning`. The latter is used by `amp-ad` and `amp-video`. The purpose is to allow a single `also_requires_tag_warning` to cover all variations of script types (regular, module, nomodule, module SXG) with a single expression (`amp-ad extension script`). The engine will see this and apply it to any extension script type. That change will come in part 2. This changes: `amp-extname extension .js script` to `amp-extname extension script` `amphtml engine v0.js script` to `amphtml engine script` PiperOrigin-RevId: 339147096 * Alternative tagspecs may meet also_requires_tag_warning requirements This is part 2 of 2. Part 1 is cl/339147096. The purpose is to allow a single `also_requires_tag_warning` to cover all variations of script types (regular, module, nomodule, module SXG) with a single expression (e.g. `amp-ad extension script`). The engine will see `extension script` and apply it to any extension script type with the same extension spec name. PiperOrigin-RevId: 339898343 Co-authored-by: honeybadgerdontcare <sedano@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request.