Commits on Nov 3, 2020

1. Remove the file extension for script tags in spec_names/messages (.js) …

   This is part 1 of 2.
   
   With the introduction of module/nomodule the file extension for scripts may
   be either `.js` or `.mjs` and not always `.js`. This change will allow for the
   simplification of handling `also_requires_tag` and `also_requires_tag_warning`.
   The latter is used by `amp-ad` and `amp-video`.
   
   The purpose is to allow a single `also_requires_tag_warning` to cover all
   variations of script types (regular, module, nomodule, module SXG) with a
   single expression (`amp-ad extension script`). The engine will see this and
   apply it to any extension script type. That change will come in part 2.
   
   This changes:
   
   `amp-extname extension .js script` to `amp-extname extension script`
   `amphtml engine v0.js script` to `amphtml engine script`
   
   PiperOrigin-RevId: 339147096

   

   honeybadgerdontcare authored and amaltas committed Nov 3, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for d140723
   • Browse repository at this point

   Copy the full SHA

   d140723 View commit details

   Browse the repository at this point in the history

2. Alternative tagspecs may meet also_requires_tag_warning requirements …

   This is part 2 of 2. Part 1 is cl/339147096.
   
   The purpose is to allow a single `also_requires_tag_warning` to cover all
   variations of script types (regular, module, nomodule, module SXG) with a
   single expression (e.g. `amp-ad extension script`). The engine will see
   `extension script` and apply it to any extension script type with the same
   extension spec name.
   
   PiperOrigin-RevId: 339898343

   

   honeybadgerdontcare authored and amaltas committed Nov 3, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 1666f40
   • Browse repository at this point

   Copy the full SHA

   1666f40 View commit details

   Browse the repository at this point in the history