✨ [amp-autocomplete] Add support for prefetch attribute for prefetching remote data
#31021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @caroqliu |
caroqliu
reviewed
Nov 9, 2020
There was a problem hiding this comment.
LGTM, however note that users cannot start using this attribute until it is allowed in the validation rules. Please allow prefetch and update the validator tests too. :)
|
Thanks for your comments @caroqliu. I've updated the validation rules and added tests, PTAL. |
caroqliu
approved these changes
Nov 10, 2020
|
Thanks for approving. I've already updated the documentation in |
honeybadgerdontcare
requested changes
Nov 10, 2020
extensions/amp-autocomplete/validator-amp-autocomplete.protoascii
Outdated
Show resolved
Hide resolved
extensions/amp-autocomplete/validator-amp-autocomplete.protoascii
Outdated
Show resolved
Hide resolved
🤦♀️ You're right! Ignore me :) |
honeybadgerdontcare
approved these changes
Nov 10, 2020
zhouyx
approved these changes
Nov 10, 2020
twifkak
pushed a commit
to twifkak/amphtml
that referenced
this pull request
Nov 18, 2020
Merged
twifkak
added a commit
that referenced
this pull request
Nov 18, 2020
* cl/341717450 Revision bump for #31021 * cl/342729148 Revision bump for #31099 * cl/342767641 Revision bump for #31056 * cl/342951159 Fix blurry-placeholder test cases * cl/342977800 Restricts value of transformed attribute Co-authored-by: Michael Rybak <michaelrybak@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com>
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
…hing remote data (ampproject#31021) * Add support for `prefetch` attribute * Update validation rules and add test * Update validator-amp-autocomplete.out * Address code review comments
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* cl/341717450 Revision bump for ampproject#31021 * cl/342729148 Revision bump for ampproject#31099 * cl/342767641 Revision bump for ampproject#31056 * cl/342951159 Fix blurry-placeholder test cases * cl/342977800 Restricts value of transformed attribute Co-authored-by: Michael Rybak <michaelrybak@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prefetchattributeResolves #24687