Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator rollup #31252

Merged
merged 5 commits into from Nov 18, 2020
Merged

Validator rollup #31252

merged 5 commits into from Nov 18, 2020

Conversation

twifkak
Copy link
Member

@twifkak twifkak commented Nov 18, 2020

@twifkak twifkak requested a review from banaag November 18, 2020 21:13
@amp-owners-bot
Copy link

amp-owners-bot bot commented Nov 18, 2020 •
edited by ampprojectbot

Hey @ampproject/wg-caching! These files were changed:

validator/js/engine/validator.js
validator/testdata/transformed_feature_tests/amp_boilerplate_missing.html
validator/testdata/transformed_feature_tests/amp_boilerplate_missing.out
validator/testdata/transformed_feature_tests/blurry_image_placeholder.html
validator/testdata/transformed_feature_tests/blurry_image_placeholder.out
validator/testdata/transformed_feature_tests/server_side_rendering.html
validator/testdata/transformed_feature_tests/server_side_rendering.out
validator/testdata/transformed_feature_tests/transformed_attribute_value_malformed.html
validator/testdata/transformed_feature_tests/transformed_attribute_value_malformed.out
validator/testdata/transformed_feature_tests/transformed_attribute_value_version_malformed.html
validator/testdata/transformed_feature_tests/transformed_attribute_value_version_malformed.out
validator/validator-main.protoascii

@twifkak twifkak merged commit e630feb into ampproject:master Nov 18, 2020
@twifkak twifkak deleted the rollup branch November 18, 2020 21:44
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@twifkak @MichaelRybak
@honeybadgerdontcare @ed-bird
Validator rollup (ampproject#31252)
97c43b8 
* cl/341717450 Revision bump for ampproject#31021

* cl/342729148 Revision bump for ampproject#31099

* cl/342767641 Revision bump for ampproject#31056

* cl/342951159 Fix blurry-placeholder test cases

* cl/342977800 Restricts value of transformed attribute

Co-authored-by: Michael Rybak <michaelrybak@google.com>
Co-authored-by: honeybadgerdontcare <sedano@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honeybadgerdontcare honeybadgerdontcare honeybadgerdontcare approved these changes

@banaag banaag Awaiting requested review from banaag

Assignees
No one assigned
Labels
PR use: In Beta / Experimental WG: caching
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@twifkak @honeybadgerdontcare @ampprojectbot @MichaelRybak