Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚮 Sweep experiments (demo) #31461

Closed
wants to merge 14 commits into from
Closed

Conversation

alanorozco
Copy link
Member

@alanorozco alanorozco commented Dec 5, 2020

Sweep experiments last flipped globally up to 2019-12-06:


⚠️ This changes Javascript source files

The following may contain errors and/or require intervention to remove superfluous conditionals:

  • extensions/amp-access/0.1/amp-access-source.js
  • extensions/amp-access/0.1/test/test-amp-access-source.js
  • extensions/amp-action-macro/0.1/amp-action-macro.js
  • extensions/amp-action-macro/0.1/test/test-amp-action-macro.js
  • extensions/amp-playbuzz/0.1/amp-playbuzz.js
  • extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js
  • extensions/amp-sidebar/0.1/amp-sidebar.js
  • extensions/amp-sidebar/0.2/amp-sidebar.js
  • extensions/amp-story/1.0/amp-story.js
  • extensions/amp-story/1.0/test/test-amp-story.js
  • src/runtime.js
  • test/unit/test-runtime.js

⚠️ There are HTML files with possible references

The following HTML files contain references to experiment names which may be stale and should be manually removed:

  • examples/playbuzz.amp.html
  • examples/responsive-menu.amp.html
  • examples/visual-tests/amp-mega-menu/amp-mega-menu.amp.html
  • examples/visual-tests/amp-mega-menu/amp-mega-menu-with-list.amp.html
  • examples/amp-action-macro.html
  • test/manual/amp-mega-menu/amp-mega-menu.amp.html
  • test/manual/amp-mega-menu/amp-mega-menu-with-list.amp.html

prod-config.json history:

 - 4eccc14 - 2018-07-23T12:02:56-07:00
   Launch amp-access-iframe experiment (ampproject#17012)
prod-config.json history:

 - 0ab715e - 2019-10-01T10:32:36-04:00
   Launch <amp-action-macro> (ampproject#24810)
prod-config.json history:

 - fa7417d - 2019-11-08T14:05:29-08:00
   Launch amp-mega-menu to 100% of canary and production (ampproject#25480)
prod-config.json history:

 - ee0ad23 - 2019-11-13T19:55:39-08:00
   Launch amp-nested-menu to 100% of production and canary (ampproject#25516)
prod-config.json history:

 - eeebd93 - 2017-02-07T12:10:35-08:00
   Launch make-body-relative (ampproject#7403)

 - 5e5173b - 2017-02-02T12:48:07-08:00
   Clean up `amp-selector` experiment (ampproject#7305)

 - f627a36 - 2017-01-10T14:14:28-08:00
   Launch amp-selector (ampproject#6969)
prod-config.json history:

 - 24ceaf5 - 2019-10-21T18:23:19-04:00
   ramp up experiment for sidebar swipe-to-dismiss (ampproject#25170)
prod-config.json history:

 - d26327a - 2018-11-05T12:02:25-05:00
   Re-launch amp-story-responsive-units experiment (ampproject#19140)

 - d5ec88b - 2018-10-30T16:01:59-07:00
   Unlaunch amp-story-responsive-units for urgent release (ampproject#19057)

 - 65379df - 2018-10-26T15:27:09-04:00
   Launch amp-story-responsive-units experiment (ampproject#18989)
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 1194c16 - 2018-06-12T11:38:38-04:00
   Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 34ffcdb - 2017-02-17T13:10:59-08:00
   turn on chunked-amp (ampproject#7645)
…lection`: 0

prod-config.json history:

 - 4ca1409 - 2019-10-28T15:54:36+00:00
   Ramp down inconsistent height selection fix experiment to 0%. This doesn't work very well on desktop / tablet so we need to fix that before proceeding. (ampproject#25269)
prod-config.json history:

 - 27ccef3 - 2019-02-26T14:10:25-05:00
   Enable  in canary/prod. (ampproject#21058)
prod-config.json history:

 - ca20059 - 2017-05-16T09:31:30-04:00
   Start Doubleclick Fast Fetch potential SRA delay measure experiment (ampproject#9298)
prod-config.json history:

 - 31f7e22 - 2019-11-12T09:11:14-08:00
   🐛 Pass through applicable AMP experiments to SwG (ampproject#25512)
Sweep experiments last flipped globally up to 2019-12-04:

- (2018-07-23, ampproject#17012) `amp-access-iframe`: 1
- (2019-10-01, ampproject#24810) `amp-action-macro`: 1
- (2019-11-08, ampproject#25480) `amp-mega-menu`: 1
- (2019-11-13, ampproject#25516) `amp-nested-menu`: 1
- (2017-02-07, ampproject#7403) `amp-playbuzz`: 1
- (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1
- (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1
- (2018-07-11, ampproject#16678) `amp-story-v1`: 1
- (2018-07-11, ampproject#16678) `chunked-amp`: 1
- (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0
- (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1
- (2017-05-16, ampproject#9298) `pump-early-frame`: 1
- (2019-11-12, ampproject#25512) `swg-gpay-native`: 1

---

**⚠️ This changes Javascript source files**

The following may contain errors and/or require intervention to remove superfluous conditionals:

- `extensions/amp-access/0.1/amp-access-source.js`
- `extensions/amp-access/0.1/test/test-amp-access-source.js`
- `extensions/amp-action-macro/0.1/amp-action-macro.js`
- `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`
- `extensions/amp-playbuzz/0.1/amp-playbuzz.js`
- `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js`
- `extensions/amp-sidebar/0.1/amp-sidebar.js`
- `extensions/amp-sidebar/0.2/amp-sidebar.js`
- `extensions/amp-story/1.0/amp-story.js`
- `extensions/amp-story/1.0/test/test-amp-story.js`
- `src/runtime.js`
- `test/unit/test-runtime.js`
@alanorozco alanorozco marked this pull request as draft December 5, 2020 07:07
@ampproject ampproject deleted a comment from amp-owners-bot bot Dec 5, 2020
@alanorozco alanorozco removed the request for review from Gregable December 5, 2020 07:07
@alanorozco
Copy link
Member Author

This PR is a demo for a generating tool and is not meant to be submitted.

@lgtm-com
Copy link

lgtm-com bot commented Dec 5, 2020

This pull request introduces 5 alerts when merging 25680d8 into b445001 - view on LGTM.com

new alerts:

  • 5 for Useless conditional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant