remove IS_AMP_ALT #31493
Merged
remove IS_AMP_ALT #31493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jridgewell! These files were changed: |
|
🔥 🔥 🔥 🔥 Love this 🔥 🔥 🔥 🔥 🔥 |
samouri
reviewed
Dec 8, 2020
| * v0.js code. | ||
| * @type {boolean|undefined} | ||
| */ | ||
| const shouldMainBootstrapRun = !self.IS_AMP_ALT; |
There was a problem hiding this comment.
According to the description, don't we still need this variable for amp-inabox and amp-shadow?
There was a problem hiding this comment.
sorry late reply. this should have been only needed for single pass, if theres any other description i haven't removed about it, could you point it out? thanks
erwinmombay
force-pushed
the
remove-is-amp-alt
branch
from
97d67bd
to
b957076
Compare
|
This pull request introduces 1 alert when merging b957076 into 2f0ac6e - view on LGTM.com new alerts:
|
jridgewell
requested changes
Jan 16, 2021
erwinmombay
force-pushed
the
remove-is-amp-alt
branch
3 times, most recently
from
89e601d
to
9d862ac
Compare
jridgewell
approved these changes
Jan 20, 2021
erwinmombay
force-pushed
the
remove-is-amp-alt
branch
from
9d862ac
to
5d3a4e9
Compare
This flag was only needed for single pass which is abandoned
erwinmombay
force-pushed
the
remove-is-amp-alt
branch
from
5d3a4e9
to
137d6fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag was only needed for single pass which is abandoned