Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Refactor and simplify build target logic during CI builds #32146

Merged
merged 1 commit into from
Jan 25, 2021
Merged

🏗 Refactor and simplify build target logic during CI builds #32146

merged 1 commit into from
Jan 25, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jan 22, 2021 •
edited

PR highlights:

  • Add the Targets enum to build-targets.js
  • Add buildTargetsInclude() to check if a PR's build targets include the given target(s)
  • Cache the set of build targets once they have initially been determined
  • Eliminate the hundreds of spots where build targets are referenced by name
  • Modify reportAllExpectedTests() to use the previously computed build targets
  • Fix bug where a nonexistent target was still being checked (VALIDATOR_JAVA no longer exists)

@rsimha rsimha self-assigned this Jan 22, 2021
@rsimha rsimha merged commit 11d16c9 into ampproject:master Jan 25, 2021
@rsimha rsimha deleted the 2021-01-22-BuildTargets branch January 25, 2021 17:04
This was referenced Jan 26, 2021
Merged
Merged
PetrBlaha pushed a commit to PetrBlaha/amphtml that referenced this pull request Jan 28, 2021
@rsimha @PetrBlaha
🏗 Refactor and simplify build target logic during CI builds (ampproje…
d80fd55 
…ct#32146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielrozenberg danielrozenberg danielrozenberg approved these changes

@erwinmombay erwinmombay Awaiting requested review from erwinmombay

@kristoferbaxter kristoferbaxter Awaiting requested review from kristoferbaxter

Assignees

@rsimha rsimha

Labels
PR use: In Beta / Experimental PR use: In Stable WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rsimha @danielrozenberg @ampprojectbot