Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Add the missing DOCS build target to the Targets enum in build-targets.js #32227

Merged
merged 2 commits into from
Jan 26, 2021
Merged

🏗 Add the missing DOCS build target to the Targets enum in build-targets.js #32227

merged 2 commits into from
Jan 26, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jan 26, 2021

Adding an item I left out in #32146. I believe DOCS changes were defaulting to RUNTIME. Now, they will be correctly processed.

I also figured it was worth addressing your concern in #32146 (comment), so did that as well.

@rsimha rsimha self-assigned this Jan 26, 2021
@rsimha rsimha merged commit 6da0658 into ampproject:master Jan 26, 2021
@rsimha rsimha deleted the 2021-01-26-DocsTarget branch January 26, 2021 21:57
PetrBlaha pushed a commit to PetrBlaha/amphtml that referenced this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants