Turn on more aggressive compiler optimizations. #3223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
25KB pre-gzip win on v0.js :) |
|
woot, good stuff. |
|
@cramforce guessing this would also have an improvement on eval time? |
cramforce
force-pushed
the
nocollapse
branch
2 times, most recently
from
bcd762e
to
6d61eb1
Compare
|
Got another 4KB improvement. |
cramforce
changed the title
|
@erwinmombay Please take a look. I removed the property renaming from this change. Little size impact, but having the externs in place and such will make the next change easier. |
|
I guess 10K pre-gzip on main binary is still kinda worth it anyway :) |
| // AMP's globals | ||
| window.AMP_TEST; | ||
| window.AMP_TAG; | ||
| window.AMP = {}; |
There was a problem hiding this comment.
do we need to add window.AMP_CONFIG
cramforce
force-pushed
the
nocollapse
branch
2 times, most recently
from
c4c0982
to
079f063
Compare
|
@cramforce LGTM |
cramforce
force-pushed
the
nocollapse
branch
3 times, most recently
from
812a753
to
6e0fd8d
Compare
- allows devirtualization of private methods. - allows renaming of private properties and methods. - Aliases `.prototype.` pattern where useful. - other less important optimizations. Implements a coding convention for AMP that marks all properties not ending in `_` as exported (so they can travel between compilation units). This change by itself has little size impact, but should make our code quite a bit tighter to execute, because many virtual private method calls because function calls. Primarily this is a preparation to turn on private property renaming when the upstream change lands in closure compiler.
blickly
pushed a commit
to google/closure-compiler
that referenced
this pull request
Jun 6, 2016
…coding convention. This is a slight change in behavior for projects based on the GoogleCodingConvention that considers properties starting with "_" to be exported, which should be very rare under this convention. Compiler change prototyped in ampproject/amphtml#3223 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=124020030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.prototype.pattern where useful.Implements a coding convention for AMP that marks all properties not ending in
_as exported (so they can travel between compilation units).
This change by itself has little size impact, but should make our code quite a bit tighter to execute, because many virtual p
rivate method calls because function calls. Primarily this is a preparation to turn on private property renaming when the ups
tream change lands in closure compiler.