📖 [amp-analytics] Document async var resolutions (in relation to CWV) #32394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristoferbaxter
approved these changes
Feb 4, 2021
| @@ -476,6 +476,13 @@ In addition, all of the variables supported by | |||
| [AMP HTML Substitutions Guide](../../spec/amp-var-substitutions.md) | |||
| are also supported. | |||
|
|
|||
| Variables are resolved asynchronously and can delay the request until they are | |||
There was a problem hiding this comment.
are or can?
I'd assume some are resolved synchronously or close enough to sync to not be a factor.
There was a problem hiding this comment.
Yeah, some async ones may resolve quickly.
| Largest Contentful Paint are calculated after the page is hidden. For First | ||
| Input Delay, it is resolved after the user interacts with the page. For this | ||
| reason these metrics might not be suitable for use with all triggers (for | ||
| example, on timer or visible). |
There was a problem hiding this comment.
Looks good: QQ though, did we add a specific trigger for when all these values have been captured?
There was a problem hiding this comment.
No specific trigger, however using something like page view would allow the trigger to be fired immediately, and only wait for the CWV macros to resolve, before sending.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30940
Document that variables are fulfilled async--which could affect collection of CWV.