Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃彈 Run experiment tests during PR builds #32574

Merged
merged 2 commits into from
Feb 11, 2021
Merged

馃彈 Run experiment tests during PR builds #32574

merged 2 commits into from
Feb 11, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Feb 10, 2021 •
edited

This should help identify Experiment test failures before they hit master. Initially, we will probably see more PR job failures, but over time, our experiment code will be more solidly tested.

Addresses #32581 (comment)

@rsimha rsimha self-assigned this Feb 10, 2021
@amp-owners-bot
Copy link

Hey @estherkim! These files were changed:

build-system/tasks/e2e/index.js

@rsimha rsimha requested a review from caroqliu February 10, 2021 16:15
@rsimha rsimha mentioned this pull request Feb 10, 2021
Merged
caroqliu
caroqliu approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@caroqliu caroqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃帀 馃帀 馃帀 Thank you!

Wanted to include the output from running locally on your branch

gulp integration --nobuild --files=test/integration/test-extensions-loading.js --compiled --define_experiment_constant BENTO_AUTO_UPGRADE

image

@rsimha
Copy link
Contributor Author

rsimha commented Feb 11, 2021

Yay! Everything is green. Merging now. 馃

image

@rsimha rsimha merged commit 0919da4 into ampproject:master Feb 11, 2021
@rsimha rsimha deleted the 2021-02-09-ExperimentBuilds branch February 11, 2021 00:32
@rsimha rsimha mentioned this pull request Feb 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvoytenko dvoytenko dvoytenko left review comments

@caroqliu caroqliu caroqliu approved these changes

@estherkim estherkim estherkim approved these changes

Assignees

@rsimha rsimha

Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rsimha @dvoytenko @caroqliu @estherkim @ampprojectbot