Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃彈 Split experiment builds and tests into separate jobs #32614

Merged
merged 1 commit into from
Feb 11, 2021
Merged

馃彈 Split experiment builds and tests into separate jobs #32614

merged 1 commit into from
Feb 11, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Feb 11, 2021

In #32574, we added experiment tests to the PR build workflow so that AMP code could be more solidly tested before merge.

This PR splits the building and testing of experiments into two separate jobs. There are a few advantages:

  • Tests (which run serially anyway) now use a lower power VM (5x cheaper), so saves $$
  • Rerunning tests will not need a full rebuild, saving time and $$
  • We can now deploy experiment code via PR deploy if we want to

It also removes the now inaccurate and no longer used experiment stage from Travis (we're shutting it down soon)

Results: link

image

Future work: Speed up E2E tests #32616

Follow up to #32574

@rsimha rsimha self-assigned this Feb 11, 2021
@rsimha rsimha marked this pull request as ready for review February 11, 2021 16:38
@rsimha rsimha merged commit 5319875 into ampproject:master Feb 11, 2021
@rsimha rsimha deleted the 2021-02-11-ExperimentBuild branch February 11, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants