Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃彈 Switch to @jridgewell/doctrine package #32895

Merged
merged 2 commits into from Feb 26, 2021
Merged

馃彈 Switch to @jridgewell/doctrine package #32895

merged 2 commits into from Feb 26, 2021

Conversation

jridgewell
Copy link
Contributor

My fork handles ./foo.Bar relative file types

@amp-owners-bot
Copy link

amp-owners-bot bot commented Feb 25, 2021 •
edited

Hey @erwinmombay! These files were changed:

build-system/eslint-rules/closure-type-primitives.js

Hey @gmajoulet, @newmuis, @Enriqe! These files were changed:

extensions/amp-story/1.0/amp-story-page.js

@jridgewell
Switch to @jridgewell/doctrine package
552691d 
My fork handles `./foo.Bar` relative file types
@jridgewell
Fix types
f86797b
@kristoferbaxter kristoferbaxter merged commit 6a86004 into ampproject:master Feb 26, 2021
@jridgewell jridgewell deleted the doctrine branch February 26, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoferbaxter kristoferbaxter kristoferbaxter approved these changes

@erwinmombay erwinmombay erwinmombay approved these changes

@Enriqe Enriqe Enriqe approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jridgewell @kristoferbaxter @erwinmombay @Enriqe @ampprojectbot