Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Switch to @jridgewell/doctrine package #32895

Merged
merged 2 commits into from
Feb 26, 2021
Merged

🏗 Switch to @jridgewell/doctrine package #32895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
552691d
Switch to @jridgewell/doctrine package
jridgewell Feb 25, 2021
f86797b
Fix types
jridgewell Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion build-system/eslint-rules/closure-type-primitives.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/
'use strict';

const doctrine = require('doctrine');
const doctrine = require('@jridgewell/doctrine');
const traverse = require('traverse');

/** @typedef {!Object} */
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-skimlinks/0.1/link-rewriter/link-rewriter-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export class LinkRewriterManager {
/**
* Create and configure a new LinkRewriter on the page.
* @param {string} linkRewriterId - A unique id used to identify the link rewriter.
* @param {!function(!Array<!HTMLElement>): !./two-steps-response.TwoStepsResponse} resolveUnknownLinks
* @param {function(!Array<!HTMLElement>): !./two-steps-response.TwoStepsResponse} resolveUnknownLinks
* - Function to determine which anchor should be replaced and by what URL.
* Should return an instance of './two-steps-response.TwoStepsResponse'.
* @param {?{linkSelector: string}=} options
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-story/1.0/amp-story-page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,7 @@ export class AmpStoryPage extends AMP.BaseElement {
/**
* Applies the specified callback to each media element on the page, after the
* media element is loaded.
* @param {!function(!./media-pool.MediaPool, !Element)} callbackFn The
* @param {function(!./media-pool.MediaPool, !Element)} callbackFn The
* callback to be applied to each media element.
* @return {!Promise} Promise that resolves after the callbacks are called.
* @private
Expand Down
9 changes: 9 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
"@babel/preset-env": "7.12.17",
"@chiragrupani/karma-chromium-edge-launcher": "2.1.0",
"@jest/core": "26.6.3",
"@jridgewell/doctrine": "3.0.2",
"@sinonjs/fake-timers": "7.0.2",
"@types/fancy-log": "1.3.1",
"@types/minimist": "1.2.1",
Expand Down Expand Up @@ -84,7 +85,6 @@
"debounce": "1.2.0",
"del": "6.0.0",
"derequire": "2.1.1",
"doctrine": "3.0.0",
"envify": "4.1.0",
"enzyme": "3.11.0",
"enzyme-adapter-preact-pure": "3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion src/service/resources-impl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export class ResourcesImpl {
/** @const {!TaskQueue} */
this.queue_ = new TaskQueue();

/** @const {!function(./task-queue.TaskDef):number} */
/** @const {function(./task-queue.TaskDef):number} */
this.boundTaskScorer_ = this.calcTaskScore_.bind(this);

/**
Expand Down