✨ [Story video] Create service to build the cache url #33421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 4db83f6 into 56e28aa - view on LGTM.com new alerts:
|
mszylkowski
changed the title
|
This pull request introduces 1 alert when merging 59890a2 into f74b277 - view on LGTM.com new alerts:
|
mszylkowski
requested review from
gmajoulet
and removed request for
kristoferbaxter and
rileyajones
gmajoulet
reviewed
Mar 23, 2021
|
Can you also update the PR's name? |
mszylkowski
changed the title
gmajoulet
approved these changes
Mar 23, 2021
|
cc @danielrozenberg for owners approval
|
danielrozenberg
approved these changes
Mar 24, 2021
gmajoulet
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates the
amp-cache-urlextension that installs the service foramp-toolbox-cache-url