Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⏪ Revert import changes for assertions #33434

Merged
merged 4 commits into from
Mar 24, 2021

Conversation

rcebulko
Copy link
Contributor

Basically a revert of #32828

I was trying to update imports of assertions in waves. During my attempt at a second wave, I discovered a bunch of mostly untested functionality depending on the existing AMP assertion logic, suggesting the swap is not quite so clean. Undoing these changes, and will just make src/log.js#assert wrap src/core/assert.js#assertion; new code/code in src/{context,preact,core} can use the dependency-free helper, and existing AMP code can me migrated manually (or not).

@amp-owners-bot
Copy link

Hey @Jiaming-X! These files were changed:

extensions/amp-ad-network-adsense-impl/0.1/adsense-shared-state.js

Hey @jeffkaufman! These files were changed:

extensions/amp-ad-network-adsense-impl/0.1/adsense-shared-state.js
extensions/amp-ad-network-doubleclick-impl/0.1/test/test-doubleclick-sra.js

Hey @alanorozco! These files were changed:

extensions/amp-connatix-player/0.1/amp-connatix-player.js
extensions/amp-delight-player/0.1/amp-delight-player.js
extensions/amp-kaltura-player/0.1/amp-kaltura-player.js
extensions/amp-o2-player/0.1/amp-o2-player.js
extensions/amp-redbull-player/0.1/amp-redbull-player.js
extensions/amp-springboard-player/0.1/amp-springboard-player.js

Hey @gmajoulet, @newmuis, @Enriqe! These files were changed:

extensions/amp-story/1.0/animation-presets.js
extensions/amp-story/1.0/bookend/components/article.js
extensions/amp-story/1.0/bookend/components/cta-link.js
extensions/amp-story/1.0/bookend/components/heading.js
extensions/amp-story/1.0/bookend/components/landscape.js
extensions/amp-story/1.0/bookend/components/portrait.js
extensions/amp-story/1.0/bookend/components/text-box.js
extensions/amp-story/1.0/live-story-manager.js
extensions/amp-story/1.0/pagination-buttons.js
extensions/amp-story/1.0/simple-template.js

@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request introduces 1 alert when merging 30aee38 into 843d597 - view on LGTM.com

new alerts:

  • 1 for Invocation of non-function

@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request introduces 1 alert when merging 77710c7 into 7dac0bb - view on LGTM.com

new alerts:

  • 1 for Invocation of non-function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants