🏗️ Ignore .babel-cache directory #33449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensure prettier respects its .prettierignore file, which for some reason it ignores when using the API vs the CLI.
rsimha
reviewed
Mar 23, 2021
rsimha
approved these changes
Mar 24, 2021
rsimha
reviewed
Mar 24, 2021
build-system/tasks/prettify.js
Outdated
| // Prettier ignores the `.prettierignore` file when using the API like we | ||
| // are. So we need to filter our files down before feeding them to the API. | ||
| const ignore = fs.readFileSync('.prettierignore', 'utf8'); | ||
| const filesToCheck = getFilesToCheck(prettifyGlobs, {dot: true, ignore}); |
There was a problem hiding this comment.
I think this should be passed in separately via a new param called ignoreFile. Directly adding an ignore field to options will pass it in to globby.sync, and I'm not sure the formats match. (This is a single string containing a block of files, which I'm not sure globby.sync knows to parse.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensure prettier respects its
.prettierignorefile, which for some reason it ignores when using the API vs the CLI.