🏗 Consolidate arg processing and file globbing / ignoring across amp tasks
#33505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
Mar 25, 2021
rsimha
changed the title
amp tasks
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the idea that I did a terrible job of describing in #33449 (comment) and #33462 (comment). Now that there is a way to explicitly ignore patterns from an ignore file like
.prettierignoreor.eslintignore, we can get rid of a bunch of unnecessary code inlint.js.Bonus cleanup: The logic in
eslintRulesChanged()to force-lint the entire repo if even a single rule changed was more trouble than it was worth during local development, so I've removed it. (We already lint all files during CI, there's no reason to annoy developers when they're runningamp lint --local_changes.)