✨ [Amp story] [Page attachments] [inline] Add contrast protection #33939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet, @newmuis, @Enriqe! These files were changed: |
mszylkowski
reviewed
Apr 21, 2021
processprocess
force-pushed
the
background-protection
branch
from
63577a7
to
fdd81c1
Compare
gmajoulet
approved these changes
Apr 21, 2021
Enriqe
approved these changes
Apr 21, 2021
mszylkowski
approved these changes
Apr 21, 2021
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
…pproject#33939) * Themed linear gradient. * Themed background protection * Target by href * Comment code. * Consolidate css.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context / Fixes #33913
Add contrast protection for inline attachments.
demo
The theming for "no image pre-tap dark theme" will be added in #32767