Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ amp-story-desktop-one-panel Position distance="2" page below viewport #34834

Merged
merged 2 commits into from
Jun 15, 2021
Merged

✨ amp-story-desktop-one-panel Position distance="2" page below viewport #34834

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da14b7f
vh instead of %
processprocess Jun 11, 2021
7df66b2
change to VH
processprocess Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/amp-story/1.0/amp-story.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ amp-story-page[distance="1"] {
}

amp-story-page[distance="2"] {
transform: translateY(100%) !important;
transform: translateY(100vh) !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we could just change it to 100vh all the time.
The historical context behind the 100% is that it's hard to trust VH because of browser expanded/minified UIs on user scroll. 100vh is not always 100%.

If you know the answer to this question (always using 100vh) and feel confident about it, plz do it. If not sure, let's keep it this way and simply move the override to the onepanel CSS file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK it should be fine, since 100vh >= 100%, so it should still be off-screen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK it should be fine, since 100vh >= 100%, so it should still be off-screen.

Agreed that in this case we can use 100vh since it will always be off screen. Lets go that route.

}

amp-story-page [data-text-background-color] {
Expand Down