✨ amp-story-desktop-one-panel Position distance="2" page below viewport
#34834
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
| @@ -275,6 +275,10 @@ amp-story-page[distance="2"] { | |||
| transform: translateY(100%) !important; | |||
| } | |||
|
|
|||
| .i-amphtml-story-desktop-one-panel amp-story-page[distance="2"] { | |||
There was a problem hiding this comment.
Plz move to the one-panel CSS file
| @@ -275,6 +275,10 @@ amp-story-page[distance="2"] { | |||
| transform: translateY(100%) !important; | |||
| } | |||
|
|
|||
| .i-amphtml-story-desktop-one-panel amp-story-page[distance="2"] { | |||
| transform: translateY(100vh) !important; | |||
There was a problem hiding this comment.
I'm wondering if we could just change it to 100vh all the time.
The historical context behind the 100% is that it's hard to trust VH because of browser expanded/minified UIs on user scroll. 100vh is not always 100%.
If you know the answer to this question (always using 100vh) and feel confident about it, plz do it. If not sure, let's keep it this way and simply move the override to the onepanel CSS file.
There was a problem hiding this comment.
AFAIK it should be fine, since 100vh >= 100%, so it should still be off-screen.
There was a problem hiding this comment.
AFAIK it should be fine, since 100vh >= 100%, so it should still be off-screen.
Agreed that in this case we can use 100vh since it will always be off screen. Lets go that route.
…ebook-like-bento-version * 'main' of github.com:ampproject/amphtml: (23 commits) `amp-story-desktop-one-panel` Update demo with usecases (ampproject#34867) 🚮 Remove src/purifier.js rollup config (ampproject#34876) Validator Rollup (ampproject#34769) ✨ `amp-story-desktop-one-panel` Check UI type to get page dimension on tap (ampproject#34875) Refactor: move getRealChildNodes and getRealChildren to core (ampproject#34813) 🏗📖 Fix some example files that do not validate (ampproject#34835) 🏗Add `#test` and `#testing` to alias list (ampproject#34853) Add css files for missing components (ampproject#34861) Apply bulk transform to html tags (ampproject#34836) 🐛 amp-ima-video: Fix duration label on livestreams (ampproject#34865) ♻️ Extract `applyFillContent` into a standalone function (ampproject#34858) Give script tag closing tag (ampproject#34832) 🏗 Refinements to renovate config (ampproject#34862) Bento: Enable `SocialShare` for npm publishing (ampproject#34817) 🏗 Use aliased paths in generated extensions (ampproject#34860) ✨ `amp-story-desktop-one-panel` Position distance="2" page below viewport (ampproject#34834) 🏗 Set `wrapper` on generated Bento extensions (ampproject#34843) 🧪[story-ads] Allow viewer to set progress bar segment experiment. (ampproject#34827) 🏗 Allow extension bundles to specify their own wrapper (ampproject#34845) 🏗🚀 Speed up validated example grouping ~45x (ampproject#34837) ...
Context / Fixes #34830
Positions
distance="2"page below viewport whenamp-story-desktop-one-panelis active.100vhwill ensure the panel will always be off of the viewport.