buildDom: simplify interface, improve docs #35209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
changed the title
samouri
force-pushed
the
simplify-buildDom
branch
from
55ddc33
to
40785b5
Compare
samouri
force-pushed
the
simplify-buildDom
branch
from
40785b5
to
2e9e0ef
Compare
rcebulko
approved these changes
Jul 23, 2021
jridgewell
approved these changes
Jul 23, 2021
samouri
force-pushed
the
simplify-buildDom
branch
2 times, most recently
from
4cf68dc
to
58bc7a6
Compare
samouri
force-pushed
the
simplify-buildDom
branch
from
58bc7a6
to
0f40636
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
buildDom. Could not get a@seeor@{link}working...no matter what I tried. If anyone knows how to make a link actually work in VS Code...I'm all ears.(Document, Element) => *toElement => *