Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗🐛 Change get-zindex to await on child process to close, not the child process's stdout stream #35244

Merged
merged 2 commits into from
Jul 15, 2021
Merged

🏗🐛 Change get-zindex to await on child process to close, not the child process's stdout stream #35244

merged 2 commits into from
Jul 15, 2021

Conversation

danielrozenberg
Copy link
Member

This should help avoid synchronization issues when running this inside Docker containers (#35176)

alanorozco
alanorozco approved these changes Jul 15, 2021
View reviewed changes
build-system/tasks/get-zindex/index.js Outdated Show resolved Hide resolved
@danielrozenberg danielrozenberg enabled auto-merge (squash) July 15, 2021 19:01
@danielrozenberg danielrozenberg merged commit 747bf43 into ampproject:main Jul 15, 2021
@danielrozenberg danielrozenberg deleted the amp-get-zindex branch July 15, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanorozco alanorozco alanorozco approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielrozenberg @alanorozco @ampprojectbot