✨ Added remote JSON functionality for amp story ads config. #35256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
calebcordry
requested changes
Jul 16, 2021
extensions/amp-story-auto-ads/0.1/test/test-amp-story-auto-ads.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-auto-ads/0.1/test/test-amp-story-auto-ads.js
Outdated
Show resolved
Hide resolved
calebcordry
reviewed
Jul 16, 2021
calebcordry
reviewed
Jul 20, 2021
calebcordry
reviewed
Jul 20, 2021
calebcordry
reviewed
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #34192
Adds the ability to have remote URLS containing config JSON data
for the component parsed and loaded
with a remote URL specified by the src attribute, instead of inline JSON only.
Both modes are still supported.
See the example included with this commit for a demo.
The inline JSON is included in this example and is commented out for reference.