Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Fix bug in instantiation of babel cache #35271

Merged
merged 2 commits into from
Jul 17, 2021
Merged

🏗 Fix bug in instantiation of babel cache #35271

merged 2 commits into from
Jul 17, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jul 16, 2021

We're seeing occasional errors during integration tests because the step that cleans old build artifacts can clash with the (too eager) instantiation of the babel cache. See #35257 (comment).

PR highlights:

  • Delay instantiation of the babel cache to just before its first use. (Artifact cleanup is guaranteed to be done by then.)
  • Bonus fix: Cosmetic fix to the logging statement that says what kind of build is being tested against.

Fixes #35257

@rsimha rsimha requested a review from samouri July 16, 2021 20:12
@rsimha rsimha self-assigned this Jul 16, 2021
@rsimha rsimha enabled auto-merge (squash) July 16, 2021 20:26
Copy link
Contributor

@kristoferbaxter kristoferbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clear with a great explanation. Thanks!

@rsimha rsimha merged commit 210cf84 into ampproject:main Jul 17, 2021
@rsimha rsimha deleted the 2021-07-16-CacheInstantiation branch July 19, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting error in existing integration test suite for certain "AMP HTML URL Variable"
3 participants