Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 [Story interactive] Post-Selection Fill Bug Fix for Image Quizzes and Polls #35274

Merged
merged 7 commits into from Jul 19, 2021

Conversation

Brandons42
Copy link
Contributor

Corrects the percentage fill to scale to the correct height based on how many users selected the option on Safari and Chrome for iOS and Safari for macOS

Demos:
https://interactive-img.web.app/fill-bug/quiz.html
https://interactive-img.web.app/fill-bug/poll.html

Fixes #35265

/cc @mszylkowski
/cc @processprocess

@amp-owners-bot amp-owners-bot bot requested a review from newmuis July 16, 2021 22:20
@amp-owners-bot
Copy link

Hey @gmajoulet, @mszylkowski! These files were changed:

extensions/amp-story-interactive/0.1/amp-story-interactive-img-poll.js
extensions/amp-story-interactive/0.1/amp-story-interactive-img-quiz.css
extensions/amp-story-interactive/0.1/amp-story-interactive-img-quiz.js
extensions/amp-story-interactive/0.1/amp-story-interactive-img.css

@mszylkowski mszylkowski requested review from processprocess and removed request for newmuis July 19, 2021 15:15
Copy link
Contributor

@processprocess processprocess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you for cross-browser testing the feature!

@mszylkowski mszylkowski added this to In progress in wg-stories Sprint via automation Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[Story interactive] Post-selection Fill Doesn't Scale for Image Quizzes and Polls on some Browsers
4 participants