馃悰 amp-story-desktop-one-panel background-blur Update blur when UI type is updated
#35279
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
| @@ -1846,6 +1846,9 @@ export class AmpStory extends AMP.BaseElement { | |||
| if (!this.backgroundBlur_) { | |||
| this.backgroundBlur_ = new BackgroundBlur(this.win, this.element); | |||
| this.backgroundBlur_.attach(); | |||
| if (this.activePage_) { | |||
| this.backgroundBlur_.update(this.activePage_.element); | |||
There was a problem hiding this comment.
If a media from this page is already used for the blur, will it early return or animate again?
There was a problem hiding this comment.
I don't think there is currently any case that there is a double call since it's called within switchTo and onUIStateUpdate_.
If the window is scaled and still on the same page, It will draw the blur again but will not animate since it's the first update of the instance.
We remove the blur from the dom at the start of every onUIStateUpdate_:
https://github.com/ampproject/amphtml/blob/main/extensions/amp-story/1.0/amp-story.js#L1824-L1825
We currently don't check or cache page media within backgroundBlur but that might be a good thing to do if want to be sure to prevent duplicate calls.
Context / Fixes #35269
Updating blur is currently called only during page change.
This PR will also update the blur when UI type is changed.
This ensures that the blur updates when resizing a window.